Skip to content

Fixed #155 Fixed bad implement, bad data structure CircularBuffer #161

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daoluong
Copy link

@daoluong daoluong commented Apr 9, 2022

Description

fixed issue #155
improve data struct:

  • Pop now work like a stack (throw InvalidOperationException when pop an empty CircularBuffer)
  • No extra item in the inner array
  • Clear array instead of create anew
  • Fixed bad implement of IEnumerable (incorrect GetEnumerator, Contains, Remove)

Checklist

  • An issue was first created before opening this pull request
  • The new code follows the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to ensure that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@hoowee
Copy link

hoowee commented Apr 9, 2022 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants