Fix JsonSchema strict to be encoded even if it's default value is true #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
strict
to be encoded when it is set totrue
inJsonSchema
additionalProperties
tojsonSchema()
test, as it is required whenstrict
istrue
What problem is this fixing?
strict
true
inJsonSchema
was never encoded to json since kotlin Json does not encode default values so openai thinks itsfalse
by defaultWhen
strict
isfalse
and schema has nested classes or lists thenChatMessage
content
gets wrapped in extra object likecontent": "{\"type\":\"object\",\"properties\":{\"isValid\":true,...
instead of expected
"content": "{\"isValid\":true,...