-
-
Notifications
You must be signed in to change notification settings - Fork 99
Surya4419/i330/unnecessary re render on sample selection #338
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Surya4419/i330/unnecessary re render on sample selection #338
Conversation
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @DianaLease @sanketshevkar , could you please review my PR when you get a chance? I’ve optimized the 'Load Sample' dropdown to prevent unnecessary re-renders and improve performance. Let me know if you have any feedback. Thanks |
…mple dropdown Signed-off-by: surya4419 <suryaa4419@gmail.com>
…mple dropdown Signed-off-by: surya4419 <suryaa4419@gmail.com>
df09853
to
bd2f8da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview output window goes blank after we change the template. I think that's why we had a loader earlier.
…mple dropdown Signed-off-by: surya4419 <suryaa4419@gmail.com>
…mple dropdown Signed-off-by: surya4419 <suryaa4419@gmail.com>
Hi @sanketshevkar ,could you please review my PR when you get a chance? |
Optimize "Load Sample" Dropdown to Prevent Unnecessary Re-renders
Closes #330
Summary
This PR optimizes the "Load Sample" dropdown functionality to ensure that only the relevant components update instead of causing a full re-render of the body section. This improves performance, reduces unnecessary API calls, and prevents UI flickering.
Changes
-Used debounced validation to prevent excessive re-renders
Screenshots or Video
(Attach any relevant screenshots or a video demonstrating the optimized behavior.)
Before
before.mp4
After
after.mp4
Related Issues
Author Checklist
--signoff
.