Skip to content

EthM370/paidEventIntegration #53

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 13 commits into
base: events_ticketing_unification
Choose a base branch
from

Conversation

EthM370
Copy link
Contributor

@EthM370 EthM370 commented Feb 14, 2025

Integrating paid event resources into event api routes + Basic UI Implementation

@EthM370 EthM370 requested review from a team as code owners February 14, 2025 22:57
Copy link
Member

@devksingh4 devksingh4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We shouldn't have a paidEvents route handler - its functionality should be integrated into the events handler with some ability to filter.
  2. individual route handlers don't need a healthz route
  3. modify the current tests for events.ts so that they test the new discriminated union functionality for events

@devksingh4
Copy link
Member

@EthM370 Just wanted to follow up since its been a while - how is progress looking on this?

@EthM370
Copy link
Contributor Author

EthM370 commented Mar 21, 2025

@devksingh4 Tarash communicated with me prior and assigned me to focus on completing link-shortener for demo and deployment, so I haven't look over this issue for the past weeks, however the current implementation I last pushed is already independent of the paid event route handler so we can safely delete that file (1 and 2 completed), I still need to modify the current tests and will get to working on that after link-shortener project.

@devksingh4 devksingh4 marked this pull request as draft March 21, 2025 19:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants