-
Notifications
You must be signed in to change notification settings - Fork 0
EthM370/paidEventIntegration #53
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: events_ticketing_unification
Are you sure you want to change the base?
EthM370/paidEventIntegration #53
Conversation
Fixed case issues during git push
…-uiuc/core-api into EthM370/paidEventIntegration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We shouldn't have a paidEvents route handler - its functionality should be integrated into the events handler with some ability to filter.
- individual route handlers don't need a healthz route
- modify the current tests for
events.ts
so that they test the new discriminated union functionality for events
@EthM370 Just wanted to follow up since its been a while - how is progress looking on this? |
@devksingh4 Tarash communicated with me prior and assigned me to focus on completing link-shortener for demo and deployment, so I haven't look over this issue for the past weeks, however the current implementation I last pushed is already independent of the paid event route handler so we can safely delete that file (1 and 2 completed), I still need to modify the current tests and will get to working on that after link-shortener project. |
Integrating paid event resources into event api routes + Basic UI Implementation