correct max rule count in survival problems #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: Add test for #126 issue
cezary986
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Dzięki za znalezienie błędu! Co do tego pull requesty miałbym dwie prośby:
- zmiana tak żeby pull request był do gałęzi
developzamiast tomain, - dodanie prostego testu jednostkowego do pliku https://github.com/adaa-polsl/RuleKit-python/blob/main/tests/test_survival.py który przed zmianami nie przechodził a teraz przechodzi.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametr
max_rule_countnie wpływał na liczbę reguł generowanych przez algorytm dla problemów przeżyciowych. Wg mojej analizy błąd wynika z tego, że parametr ten nie był de facto przekazywany do modelu ze względu na jego brak w klasie_SurvivalModelsParams. Po wprowadzeniu niniejszej poprawki parametr ten jest już brany pod uwagę. Reszta testów przechodzi, więc raczej nic nie zepsułem, ale to moja pierwsza zmiana w tej bibliotece, więc proszę o przejrzenie i ewentualne uwagi.