Skip to content

Added support for headerRowClass. #3405

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Apr 11, 2025
Merged

Added support for headerRowClass. #3405

merged 6 commits into from
Apr 11, 2025

Conversation

Agent009
Copy link
Contributor

Works similar to rowClass but gets applied on the header row.

<DataGrid ... rowClass={rowClass} headerRowClass={headerRowClass} />

@amanmahajan7
Copy link
Contributor

Can we not target header row with a grid class?

<DataGrid className="custom-header" ... />
.custom-header > .rdg-header-row {
  ...
}

@Agent009
Copy link
Contributor Author

Agent009 commented Jan 4, 2024

Can we not target header row with a grid class?

<DataGrid className="custom-header" ... />
.custom-header > .rdg-header-row {
  ...
}

Can do, but that doesn't allow for using pre-defined classes from other systems such as Tailwind. The dedicated property was added to cater for this.

@amanmahajan7
Copy link
Contributor

Can you resolve the conflicts and add a test and we can merge this PR

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (5a2c4d9) to head (ef73b0b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3405      +/-   ##
==========================================
- Coverage   98.80%   98.69%   -0.12%     
==========================================
  Files          47       47              
  Lines        3444     3451       +7     
  Branches      749      749              
==========================================
+ Hits         3403     3406       +3     
- Misses         41       45       +4     
Files with missing lines Coverage Δ
src/DataGrid.tsx 99.77% <100.00%> (+<0.01%) ⬆️
src/HeaderRow.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanmahajan7 amanmahajan7 merged commit 63fb316 into adazzle:main Apr 11, 2025
2 checks passed
@amanmahajan7
Copy link
Contributor

Thank you for the PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants