Skip to content

Passing generateGroupId props #3520

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

Luisgustavom1
Copy link
Contributor

@Luisgustavom1 Luisgustavom1 commented Jun 4, 2024

Description

In this pull request, I added the optional generateGroupId prop to the TreeDataGrid component to allow for better control over the group IDs.

Changes

  • Added the generateGroupId prop to the TreeDataGrid component.
  • This prop allows developers to generate custom group IDs based on their own logic.
  • The generateGroupId function takes a groupKey and parentId params as input and returns a generated group ID.
  • This prop provides flexibility in generating unique group IDs for each row in the grid.

Usage

To use the generateGroupId prop, simply pass a function as the value for the generateGroupId prop when rendering the TreeDataGrid component.

@amanmahajan7
Copy link
Contributor

@Luisgustavom1 can you resolve the conflicts. Thanks!

@Luisgustavom1 Luisgustavom1 force-pushed the refactor/pass-generate-group-id branch from d3ea22e to 2551615 Compare December 20, 2024 01:35
@Luisgustavom1
Copy link
Contributor Author

Luisgustavom1 commented Dec 20, 2024

@Luisgustavom1 can you resolve the conflicts. Thanks!

@amanmahajan7 resolved! can you do a review?

amanmahajan7
amanmahajan7 previously approved these changes Apr 14, 2025
Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (80e9943) to head (908868b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3520   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          47       47           
  Lines        3451     3456    +5     
  Branches      748      751    +3     
=======================================
+ Hits         3410     3415    +5     
  Misses         41       41           
Files with missing lines Coverage Δ
src/DataGrid.tsx 99.77% <ø> (ø)
src/TreeDataGrid.tsx 95.98% <100.00%> (+0.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanmahajan7 amanmahajan7 merged commit 0e5cf97 into adazzle:main Apr 14, 2025
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants