Stream command output to logger #346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @bdubertret any update on this PR from project leads? I am also interested in this feature as we have long running executables that we would like to see the log. |
moorereason
reviewed
Apr 24, 2020
| } | ||
| stderr, err := cmd.StderrPipe() | ||
| if err != nil { | ||
| log.Fatal(err) |
moorereason
reviewed
Apr 24, 2020
| log.Fatal(err) | ||
| } | ||
| if err := cmd.Start(); err != nil { | ||
| log.Fatal(err) |
moorereason
reviewed
Apr 24, 2020
| out, err := cmd.CombinedOutput() | ||
| stdout, err := cmd.StdoutPipe() | ||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
Don't call log.Fatal. Change these to something like:
log.Printf("[%s] error opening stdout: %s", rid, err)
return "", err
moorereason
requested changes
Apr 24, 2020
|
I'd be happy to rebase so we can get this live |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #345 by using a
TeeReaderon the command stdout and stderr, and streaming the output to the log as it comes from the invoked command.Following discution on my original PR #344, i have rewritten this PR to follow @moorereason 's advice (request to merge on
developmentbranch, remove unrelated commit)