Skip to content

chore(s2): update the original toaster component name on storybook #8334

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Jul 29, 2025

Conversation

kuflower
Copy link
Contributor

@kuflower kuflower commented Jun 2, 2025

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@kuflower kuflower force-pushed the s2-rename-toaster branch from e6d8c2e to c5e0544 Compare June 2, 2025 10:21
@kuflower kuflower changed the title fix(s2): rename toaster without UNSTABLE prefix storybook: update toasters to use the original component name Jun 2, 2025
@kuflower kuflower changed the title storybook: update toasters to use the original component name chore(s2): update toasters to use the original component name on storybook Jun 2, 2025
@kuflower kuflower changed the title chore(s2): update toasters to use the original component name on storybook chore(s2): update the original toaster component name on storybook Jun 2, 2025
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this was so the "Show code" block would show UNSTABLE_ToastContainer instead?

@snowystinger
Copy link
Member

I suppose this was so the "Show code" block would show UNSTABLE_ToastContainer instead?

yep, confusing to people that they couldn't use it without the prefix

@LFDanLu LFDanLu added this pull request to the merge queue Jul 29, 2025
Merged via the queue into adobe:main with commit 88db698 Jul 29, 2025
31 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants