fix: react-scan auto on playwright #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lxsmnsyc
commented
Jan 31, 2025
lxsmnsyc
commented
Jan 31, 2025
commit: |
lxsmnsyc
commented
Jan 31, 2025
|
|
||
| requestAnimationFrame(() => { | ||
| document.documentElement.appendChild(currentContainer); | ||
| }); |
There was a problem hiding this comment.
the script executed by Playwright runs such that document.documentElement is null. By using RAF we defer appending the root container.
lxsmnsyc
commented
Jan 31, 2025
| }; | ||
| startReportInterval(); | ||
| logIntro(); | ||
| requestAnimationFrame(() => { |
There was a problem hiding this comment.
Same as the previous one, we want to defer this one to ensure that the documentElement exists.
|
I'm not seeing the scans on the following:
|
|
deprecated |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, React Scan doesn't work when there isn't a React DevTools installed (since RDT initializes the global hook React listens to before React is loaded), which also makes our CLI not work properly.
This fix ensures that the auto script is loaded first before React.