Skip to content
This repository was archived by the owner on May 14, 2020. It is now read-only.

Conversation

kikonejacob
Copy link

Node items with numeric value are not rendered as the valueGetter function is not defined. This PR fix this issue by assigning a valueGetter function to nodetype of value "Number"

Node items with numeric value are not rendered as the valueGetter function is not defined. This PR fix this issue by assigning a valueGetter  function to nodetype of value "Number"
@alexkuz
Copy link
Owner

alexkuz commented Mar 6, 2017

Can you provide an example of failing data?

@kikonejacob
Copy link
Author

kikonejacob commented Mar 7, 2017

The compomemt will fail at rendering "timeout" : 5000

[{
  "type": "error",
  "message": "Timeout: Unable to communicate with the parent App",
  "params": {
    "externalCommand": "userPreferences",
    "timeout": 5000
  }
}, {
  "type": "error",
  "message": "Unable to initialize WPF Handler",
  "params": {}
}]

@alexkuz
Copy link
Owner

alexkuz commented Mar 7, 2017

Just tried it in example - seems ok to me:

2017-03-07 at 19 06

Are you using the latest version? Maybe there are some render overrides in parent component that lead to it?

@kikonejacob
Copy link
Author

kikonejacob commented Mar 7, 2017

This is a weird situation
I'm using react-json-tree 0.10.5
This is the message I'm getting :

image

My guess was that the valueGetter was not defined for node of type number.

Ref: react-json-tree/src/JSONNode.js : 53

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants