Skip to content

feat(material/slider): add customizable thumb dimensions for m2 and m3 #31439

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mistrykaran91
Copy link
Contributor

Fixes #31101

@mistrykaran91 mistrykaran91 requested a review from a team as a code owner June 25, 2025 13:58
@mistrykaran91 mistrykaran91 requested review from adolgachev and mmalerba and removed request for a team June 25, 2025 13:58
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: material/slider labels Jun 25, 2025
@mmalerba mmalerba requested review from wagnermaciel and removed request for mmalerba June 25, 2025 16:42
@wagnermaciel
Copy link
Contributor

I believe you would also need to add some logic to src/material/slider/slider-thumb.ts so that the ripple diameter is calculated based on the slider-thumb-width and slider-thumb-height

@mistrykaran91 mistrykaran91 force-pushed the feat/introduc-token-for-slider-dimensions branch from ac555fa to dba1885 Compare June 27, 2025 09:29
@mistrykaran91
Copy link
Contributor Author

I believe you would also need to add some logic to src/material/slider/slider-thumb.ts so that the ripple diameter is calculated based on the slider-thumb-width and slider-thumb-height

Thanks @wagnermaciel, I have created slider-thumb-diameter variable and used that for width and height and calculate the thumb ripple.

@mistrykaran91 mistrykaran91 force-pushed the feat/introduc-token-for-slider-dimensions branch from dba1885 to f8cab36 Compare June 27, 2025 09:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: material/slider detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(slider): Introduce token for slider height
2 participants