Fix: Enter triggers OK without extra press

[samirsuroshe18]

Purpose / Description

When an alert dialog appears after entering incorrect credentials in the sync page, pressing the Enter key only selects the "OK" button instead of triggering it. This PR modifies the behavior so that pressing Enter directly triggers the positive button action, making the user experience more intuitive.

Fixes

• Fixes Wrong password require to "enter" tap to dismiss #18340

Approach

Added an extension function setupEnterKeyHandler() to handle Enter key presses in AlertDialogs
Modified the existing show() extension function to apply this handler to all dialogs created through the builder pattern
The handler detects Enter key presses and simulates a click on the positive button if it exists and is enabled

How Has This Been Tested?

Manually verified with the following steps:

Without an AnkiWeb account on AnkiDroid
Attempted to sync
From the sync page, entered an email and wrong password
When error message appeared, pressed Enter key

🎥 Before the Fix

Click to expand

failure.webm

🎥 After the Fix

Click to expand

success.mp4

Before the fix, Enter key only selected the "OK" button requiring a second press.
After the fix, Enter key immediately dismisses the dialog.

Learning

The default behavior of AlertDialogs in Android is to only select but not trigger buttons when Enter is pressed. This is a common UI pattern that needs explicit handling to improve user experience

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[welcome]

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

[david-allison]

For reviewer 2 to confirm, but I'd rather explicitly opt-in to this on a per-dialog basis, OR find a way to make this a standard default via accessibility

This use of setOnKeyListener overrides any listeners which we set in calling code, which isn't intuitive to me.

[samirsuroshe18]

Thanks for the feedback! You're absolutely right about setOnKeyListener potentially overriding existing listeners — that could definitely lead to unexpected behavior.

To address this, I’m planning to go with an opt-in approach by modifying the show() function to accept an optional parameter:

fun AlertDialog.Builder.show(enableEnterKeyHandler: Boolean = false)

This way, setupEnterKeyHandler() will only be applied when explicitly requested, preserving backward compatibility and avoiding side effects in existing dialogs.

Let me know if this direction works for you, and I’ll update the PR accordingly.

[david-allison]

Sounds great!

[david-allison]

Perfect, cheers!

[mikehardy]

LGTM - pending merge, needs squash so has to wait for merge queue to be empty

[mikehardy]

I'm in the middle of a merge festival and the isn't going to empty until long after I've moved to other things so I rebased this one to squash it locally then force-pushed that, so I can put it in the auto queue