Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allowing to create questions without filling out body or tag field #1188

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Allowing to create questions without filling out body or tag field #1188

wants to merge 6 commits into from

Conversation

salimina
Copy link

addressing issue #1177 and #842

sy-records
sy-records requested changes Nov 29, 2024
View reviewed changes
ui/src/services/common.ts
return request.post('/answer/api/v1/question', params);
};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need add ;

ui/src/services/common.ts
@@ -117,6 +117,7 @@ export const modifyQuestion = (
return request.put(`/answer/api/v1/question`, params);
};


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless empty line

cmd/wire_gen.go
@@ -1,28 +1,8 @@
//go:build !wireinject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to revert this change.

data/conf/config.yaml
@@ -0,0 +1,21 @@
debug: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to submit data

docs/docs.go
@@ -1,22 +1,3 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ASF header needs to be preserved.

@sosyz
Copy link
Member

sosyz commented Dec 3, 2024

Thank you for your contribution and addressing these two issues! 🎉
I really appreciate your effort and would like to suggest a few minor improvements to help make this PR even better:

  1. Code Organization:

    • Could you please squash your commits into a single, clean commit?
    • You can use git squash for this, followed by git push -f to update your repository
    • Pro tip: Consider backing up your code or trying this in a new branch first if you're new to squashing

  2. Commit Message:

    • Let's enhance the commit message to better describe your changes
    • You can refer to other commits in our repository for the format
    • A good commit message helps other developers quickly understand the changes

  3. Repository Cleanup:

    • The data directory contains runtime data files which shouldn't be tracked in Git
    • Please remove this directory from your commit
    • You can do this while squashing your commits

  4. ASF Headers:

    • Please keep the original ASF headers unchanged
    • No need to include ASF header modifications in your commit

If you need any help with these changes or have questions, please don't hesitate to ask. I'm here to help! 😊

Thank you again for your contribution!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sy-records sy-records sy-records requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salimina @sosyz @sy-records