Skip to content

[FLINK-32695] [Tests] Migrated TableFactoryHarness.ScanSourceBase to Source V2 #26846

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Poorvankbhatia
Copy link
Contributor

What is the purpose of the change

This PR migrates legacy SourceFunction and SinkFunction implementations in table planner tests from the deprecated legacy APIs to the modern FLIP-27 Source API

Brief change log

  • Migrated TableFactoryHarness.ScanSourceBase from SourceFunctionProvider to SourceProvider with DataGeneratorSource
  • Migrated TableFactoryHarness.SinkBase from SinkFunctionProvider to SinkV2Provider with TestSinkV2
  • Implemented custom Source V2 in CommonExecSinkITCase.TestSource to preserve timestamp ordering
  • Updated BuiltInAggregateFunctionTestBase to use DataGeneratorSource instead of legacy SourceFunction

Verifying this change

Existing tests already cover these changes:

  • BuiltInAggregateFunctionTestBase: ModuleITCase, HashcodeITCase, MiscAggFunctionITCase, ArrayAggFunctionITCase, JsonAggregationFunctionsITCase, PercentileAggFunctionITCase
  • CommonExecSinkITCase: testStreamRecordTimestampInserterSinkRuntimeProvider and other timestamp-related tests
  • TableFactoryHarness: All dependent test cases using the harness framework

All tests pass.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 30, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Poorvankbhatia Poorvankbhatia force-pushed the FLINK-32695-TableFactoryHarness-SourceV2-Migration branch from 2a0c48a to 2bac5e3 Compare July 30, 2025 15:28
@fapaul fapaul self-requested a review August 5, 2025 09:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants