tools: Optimize size by wasm-opt #2858
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasm-opt is a tool from binaryen that can do further optimization for Wasm module, to reduce the size of bytecode. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
cederom
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Thank you @no1wudi :-)
Do we want to have it as option? You say this tool is experimental so maybe its good to make it optional just in case it produces broken binary? :-)
Does CMake build is in sync with Make build both will have this optimization enabled?
yamt
reviewed
Nov 28, 2024
| @@ -42,7 +42,12 @@ define LINK_WASM | |||
| $(if $(RETVAL), \ | |||
| $(error wasm build failed for $(PROGNAME).wasm) \ | |||
| ) \ | |||
| $(call WAMR_AOT_COMPILE) \ | |||
| $(eval RETVAL=$(shell $(WASI_SDK_PATH)/wasm-opt -Oz -o $(BINDIR)$(DELIM)wasm$(DELIM)$(PROGNAME).wasm \ | |||
There was a problem hiding this comment.
- as far as i know, wasi-sdk doesn't have wasm-opt.
- see also: Add flag to opt out of wasm-opt llvm/llvm-project#95208
There was a problem hiding this comment.
Yes, it's from binaryen, I'll update the tool path
|
ping :-) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wasm-opt is a tool from binaryen that can do
further optimization for Wasm module, to reduce
the size of bytecode.
Impact
New experimental feature, for wasm build
Testing
Local machine