nxboot/loader: Fix boot progress calculation. #3145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @TimJTi :-) How about git commit subject |
TimJTi
force-pushed
the
boot/nxboot/loader/boot.c-Incorrect-maths-for-percent-remaining-progress-display
branch
from
368097b to
6d2600b
Compare
|
@TimJTi please drop the merge patch |
It failed CI for whatever reason. So in theory I rebased and pushed. I'll take a look as in practice who knows what I did! |
|
I have zero idea what's going on. I will use a big hammer and close this PR then start again when I get a chance. |
TimJTi
force-pushed
the
boot/nxboot/loader/boot.c-Incorrect-maths-for-percent-remaining-progress-display
branch
from
47adeae to
6d2600b
Compare
Think I worked out how to do it... |
This patch corrects a mathematical error in the progress reporting function which caused incorrect percentage progress calculations. Signed-off-by: Tim Hardisty <timh@jti.uk.com>
TimJTi
force-pushed
the
boot/nxboot/loader/boot.c-Incorrect-maths-for-percent-remaining-progress-display
branch
from
6d2600b to
56e5af8
Compare
xiaoxiang781216
approved these changes
Jul 30, 2025
cederom
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch corrects a mathematical error in the progress reporting function which caused incorrect percentage progress calculations.
This problem was discovered while testing #3136.
Impact
None. Just fixes a problem where the reported % went negative and then misbehaved. Schoolboy maths error!
Testing
On my custom SAMA5D27C-D1G board using NXboot and an 800x480 nLCD with NXboot progress display enabled to view the percentage complete of various NXboot flash operations.