Static link opentelemetry-cpp libraries to otel_tracer plugin #12026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, `cmake --build build --target test` causes an error that failes to load otel_tracer.so because of undefined symbol `_ZN6google8protobuf7Message19CopyWithSourceCheckERS1_RKS1_`. Also update instructions for building and installing dependency libraries using CMake. Also update opentelemetry-cpp version to v1.19.0.
|
Could you wait for reviewing this pull request? |
Also remove unused opentelemetry libraries on OSes other than macOS.
|
I think it's ready to be reviewed now.
|
|
[approve ci autest 1] |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
cmake --build build --target testcauses an error that failes to load otel_tracer.so because of undefined symbol_ZN6google8protobuf7Message19CopyWithSourceCheckERS1_RKS1_.Also update instructions for building and installing dependency libraries using CMake.
Also update opentelemetry-cpp version to v1.19.0.