Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add nullptr check in HttpTransact::is_stale_cache_response_returnable #12108

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

masaori335
Copy link
Contributor

We faced a crash in the HttpTransact::is_stale_cache_response_returnable.

(gdb) bt
#0  0x000055ab30944655 in HttpTransact::is_stale_cache_response_returnable (s=0x7f4c475fc108) at /src/proxy/http/HttpTransact.cc:5948
#1  0x000055ab30945e58 in HttpTransact::OSDNSLookup (s=0x7f4c475fc108) at /src/proxy/http/HttpTransact.cc:1919
#2  0x000055ab309074a7 in HttpSM::call_transact_and_set_next_state (this=0x7f4c475fc000, f=<optimized out>) at /src/proxy/http/HttpSM.cc:7825
#3  0x000055ab30920942 in HttpSM::do_hostdb_lookup (this=0x7f4c475fc000) at /src/proxy/http/HttpSM.cc:4450
#4  0x000055ab3090d839 in HttpSM::state_api_callout (this=0x7f4c475fc000, event=<optimized out>) at /src/proxy/http/HttpSM.cc:1488
#5  0x000055ab3090c9a1 in HttpSM::state_api_callback (this=0x7f4c475fc000, event=60000, data=<optimized out>) at /src/proxy/http/HttpSM.cc:1295
#6  0x00007f6cb7b4b3b4 in TSHttpTxnReenable (txnp=0x7f4c475fc000, event=TS_EVENT_HTTP_CONTINUE) at /src/api/InkAPI.cc:4949
...
(gdb) p s->cache_info.object_read
$1 = (HTTPInfo *) 0x0
  • version: 10.0.4

@masaori335 masaori335 added this to the 10.2.0 milestone Mar 19, 2025
@masaori335 masaori335 self-assigned this Mar 19, 2025
@masaori335 masaori335 merged commit 5b61f23 into apache:master Mar 24, 2025
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: Ready to Merge
Status: For v10.1.0
Development

Successfully merging this pull request may close these issues.

2 participants