doc: mark sni.yaml verify_client as Inbound #12114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verify_client and verify_client_ca_certs are Inbound configurations rather than Outbound or Both.
maskit
reviewed
Mar 21, 2025
| If ``NONE`` is specified, |TS| requests no certificate. If ``MODERATE`` is specified | ||
| |TS| will verify a certificate that is presented by the client, but it will not | ||
| fail the TLS handshake if no certificate is presented. If ``STRICT`` is specified | ||
| the client must present a certificate during the TLS handshake. | ||
|
|
||
| By default this is :ts:cv:`proxy.config.ssl.client.certification_level`. | ||
|
|
||
| verify_client_ca_certs Both Specifies an alternate set of certificate authority certs to use to verify the | ||
| verify_client_ca_certs Inbound Specifies an alternate set of certificate authority certs to use to verify the |
There was a problem hiding this comment.
Looks like it was originally Outbound (incorrect) and Susan pointed out that it's for Inbound. I'm not sure how it ended up with Both.
#7676
There was a problem hiding this comment.
@masaori335 : you have thoughts? It could be I'm missing something. Should verify_client_ca_certs be Both instead of Inbound?
Thanks.
There was a problem hiding this comment.
Seem like I made mistakes. It should be Inbound.
masaori335
approved these changes
Mar 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify_client and verify_client_ca_certs are Inbound configurations rather than Outbound or Both.