Skip to content

Remove maven-antrun-plugin #2241

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ctubbsii
Copy link
Member

Replace maven-antrun-plugin with better alternatives:

  • Use build-helper-maven-plugin for keeping versions up-to-date in cclient code
  • Use build-helper-maven-plugin for retrieving hostname
  • Use Maven native env.* properties instead of antrun
  • Simplify maven-release-plugin to remove extra commit (versions should already be up-to-date from previous SNAPSHOT builds during development)
  • Use exec-maven-plugin for calling make
  • Use maven-resources-plugin for creating empty working directory
  • Use maven-resources-plugin for injecting the version into the cclient files (without the -SNAPSHOT suffix)
  • [BUGFIX] Fixes the incorrect pattern matching of version in zookeeper_version.h

Additionally, perform some minor cleanup of modified files:

  • Fix xml indentations in modified pom.xml files
  • Use ${project.build.directory} property instead of target when possible
  • [BUGFIX] Fix some paths that used semi-colons as the path separator and use the OS-dependent path separator

This fixes a few bugs (see above notes).

Replace maven-antrun-plugin with better alternatives:
* Use build-helper-maven-plugin for keeping versions up-to-date in
  cclient code
* Use build-helper-maven-plugin for retrieving hostname
* Use Maven native `env.*` properties instead of antrun
* Simplify maven-release-plugin to remove extra commit (versions should
  already be up-to-date from previous SNAPSHOT builds during
  development)
* Use exec-maven-plugin for calling make
* Use maven-resources-plugin for creating empty working directory
* Use maven-resources-plugin for injecting the version into the cclient
  files (without the `-SNAPSHOT` suffix)
* [BUGFIX] Fixes the incorrect pattern matching of version in
  `zookeeper_version.h`

Additionally, perform some minor cleanup of modified files:
* Fix xml indentations in modified pom.xml files
* Use `${project.build.directory}` property instead of target when
  possible
* [BUGFIX] Fix some paths that used semi-colons as the path separator
  and use the OS-dependent path separator

This fixes a few bugs (see above notes).
@ctubbsii
Copy link
Member Author

This change does not tag a specific JIRA issue... there were two bugs fixed in this, as a side-effect of the overall goal. I'm not sure how the ZooKeeper committers prefer to tag something like this.

@ctubbsii
Copy link
Member Author

It looks like the java fail might be related to low memory? It's not clear to me yet. I didn't modify any Java files in this PR.

@ctubbsii
Copy link
Member Author

Also, while the cppunit tests are passing in GitHub Actions, they fail for me locally, always in the same place:

./zookeeper-client/zookeeper-client-c/tests/TestReadOnlyClient.cc:118: Assertion: equality assertion failed [Expected: 0, Actual  : -15]
./zookeeper-client/zookeeper-client-c/tests/TestClient.cc:890: Assertion: equality assertion failed [Expected: 0, Actual  : -15]
Failures !!!
Run: 84   Failure total: 2   Failures: 2   Errors: 0

I'm not sure what the problem could be or how to track down the errors further.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant