-
Notifications
You must be signed in to change notification settings - Fork 196
Compilation fix for cpp-restsdk #130
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
fedeitc
wants to merge
404
commits into
api-bricks:master
Choose a base branch
from
fedeitc:cpprestsdk-compilefix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadRequestException was being thrown due to "Wrong format of time_start parameter" in Ohlcv_historical_data(string, string, DateTime, DateTime, int). The data format was hard-coded to "yyyy-MM-dd HH:ss:mm", which is invalid. It was changed to dateFormat, which is what it appears to have been changed to in all other methods.
Corrections, no semi-colons in python, please
add oms directory
…ks#123) * Add AskBid model to orderbooks instead of objects * Add book5, book20, book50 support * Add BidAskL3 model and update OrderBook3 * Upgrade project version to 2.0.0
* Update CoinApiWsClient.cs * Update CoinAPI.WebSocket.V1.csproj
* Update Symbol.cs * Update CoinAPI.REST.V1.csproj
* support for reconnecting has been added * Update pom.xml Co-authored-by: Artur Pietrzyk <Svisstack@users.noreply.github.com>
A specialization for the shared_ptr<datetime> data type was added to ModelBase member functions fromString, fromJson, toJson and toHttpContent. As ModelBase was auto generated, the real fix should be addressed by OpenAPI-Generator.
This should fix these errors:
|
fedeitc
referenced
this pull request
in fedeitc/openapi-generator
Apr 26, 2022
A specialization for the shared_ptr<datetime> data type was added to ModelBase member functions fromString, fromJson, toJson and toHttpContent. This should fix compilation errors on generated source code. See https://github.com/coinapi/coinapi-sdk/pull/130
A patch was submitted to OpenAPITools/openapi-generator#12247 |
wing328
referenced
this pull request
in OpenAPITools/openapi-generator
Apr 30, 2022
A specialization for the shared_ptr<datetime> data type was added to ModelBase member functions fromString, fromJson, toJson and toHttpContent. This should fix compilation errors on generated source code. See https://github.com/coinapi/coinapi-sdk/pull/130
This do not make sense to merge it as it will be replaced again with the openapi generator on the next change. Good to see that the fix was merged in the generator repository; lets keep this open to not lose information that this is a known issue. |
Yes, once it will be regenerated with the latest openapi generator, it will be fixed. |
819b4fc
to
ded59d3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A specialization for the
shared_ptr<datetime>
data type was added toModelBase member functions fromString, fromJson, toJson and
toHttpContent.
As ModelBase was auto generated, the real fix should be addressed by
OpenAPI-Generator.