-
Notifications
You must be signed in to change notification settings - Fork 167
Add patch for software SPI support #125
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
AranaCorp
wants to merge
5
commits into
arduino-libraries:master
Choose a base branch
from
AranaCorp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#define USE_SPI_LIB //moved line 56 defined when SOFTWARE_SPI not defined
lin20: #define USE_SPI_LIB //moved line 25
line 357, remove card.setSpiClock(clock) in function SDClass::begin(uint32_t clock, uint8_t csPin) when SOFTWARE_SPI is defined
Memory usage change @ b84ead4
Click for full report table
Click for full report CSV
|
It answers this issues #22 |
The functionality is already present but it is broken. |
I encountered the same issue today, and I confirm this fix works.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sd2Card.h line 38: #define USE_SPI_LIB moved to line 56
Sd2Card.cpp line 20: #define USE_SPI_LIB moved to line 25
SD.cpp line 357 in function SDClass::begin(uint32_t clock, uint8_t csPin), remove card.setSpiClock(clock) when SOFTWARE_SPI is defined
Description of the changes here
https://www.aranacorp.com/fr/utilisation-du-module-sd-du-shield-tft-avec-arduino-mega/