Skip to content

Ionicons v5 #16

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Ionicons v5 #16

wants to merge 9 commits into from

Conversation

arniu
Copy link
Owner

@arniu arniu commented Mar 4, 2020

@arniu
Copy link
Owner Author

arniu commented Mar 8, 2020

@JacksonLaw Would you mind reviewing the code? Thanks very much.

Copy link

@JacksonLaw JacksonLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test/glyph.spec.js work anymore? It looks for ios-{x} and md-{x} but these are no longer valid names in ionicons v5 as far as I know

@JacksonLaw
Copy link

Yes, they're all generated by the script. So, there is no need to track it.

I see, sorry my knowledge is limited. I can not see any other issues.

@arniu arniu marked this pull request as ready for review April 4, 2020 01:42
@humatic
Copy link

humatic commented Apr 5, 2020

Are you sure this is working correctly? I installed the package here and I can get icons to render using the <Icon> tag, but there is something bizarre going on. For example, when I do <Icon name="star-half-outline" size={40} color="#000000" /> I get an rendering like this:
Screenshot_20200405-114853_2
This is not correct (see the star-half-outline at ionicons.com). There is some sort of inversion going on.

@humatic
Copy link

humatic commented Apr 5, 2020

Separate issue. I had to manually load the Ionicons.ttf file using Font.loadAsync(...) (using Expo).

@arniu
Copy link
Owner Author

arniu commented Apr 6, 2020

Are you sure this is working correctly? I installed the package here and I can get icons to render using the <Icon> tag, but there is something bizarre going on. For example, when I do <Icon name="star-half-outline" size={40} color="#000000" /> I get an rendering like this:
Screenshot_20200405-114853_2
This is not correct (see the star-half-outline at ionicons.com). There is some sort of inversion going on.

Thanks very much.

@blazebarsamian
Copy link

@arniu is there any updates on this PR?

I installed this package on a project and theres a few issues. I really want to be able to use this icon set but I cant if the outline icons arent working and some icons arent even visible.

And before you suggest using version 4, I specifically need icons that were added in version 5.

@a-mazalov
Copy link

@arniu will this PR be accepted?

@arniu
Copy link
Owner Author

arniu commented Jul 2, 2020

I'm stuck on generating ttf font...

@usamaasfar
Copy link

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants