-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds Linear provider #1045
base: dev
Are you sure you want to change the base?
Adds Linear provider #1045
Conversation
[NotNull] AuthenticationProperties properties, | ||
[NotNull] OAuthTokenResponse tokens) | ||
{ | ||
using var request = new HttpRequestMessage(HttpMethod.Post, "https://api.linear.app/graphql"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linear does not have a user info endpoint and instead has a single GraphQL endpoint for all API requests. To retrieve the user info, you must build a GraphQL query and send it to the GraphQL endpoint.
Therefore, I did not consider it appropriate to use the usual pattern of setting and using the Options.UserInformationEndpoint
property in the back channel. I am happy to hear suggestions on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the new provider to the README table as well please?
} | ||
}, | ||
{ | ||
"comment": "https://docs.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs updating.
internal sealed partial class AppJsonSerializerContext : JsonSerializerContext; | ||
|
||
internal sealed record GraphqlQuery([property: JsonPropertyName("query")] string Query); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be private
?
<Project Sdk="Microsoft.NET.Sdk"> | ||
|
||
<PropertyGroup> | ||
<TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks> | |
<PackageValidationBaselineVersion>9.2.0</PackageValidationBaselineVersion> | |
<!-- TODO Remove once published to NuGet.org --> | |
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation> | |
<TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks> |
Adds a Linear provider.
Relevant docs
Authorization flow screenshots