Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds Miro provider #1046

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Adds Miro provider #1046

wants to merge 1 commit into from

Conversation

jerriep
Copy link
Contributor

@jerriep jerriep commented Mar 22, 2025

Adds a Miro provider

Relevant docs

Authorization flow screenshots

image

image

Additional notes

The Miro OAuth flow does not return the user's email address, and the API endpoints to retrieve it are available only on their Enterprise plan. Therefore, the Miro provider does not return this claim. I have added a section to the Miro provider documentation to note this.

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the new provider to the README table as well please?


public static class MiroAuthenticationExtensions
{
/// <summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <summary>
/// <summary>

<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks>
<PackageValidationBaselineVersion>9.2.0</PackageValidationBaselineVersion>
<!-- TODO Remove once published to NuGet.org -->
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
<TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks>

# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

2 participants