Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue with jsdom no longer adding window.name #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timse
Copy link

@timse timse commented Aug 9, 2022

jsdom no longer sets window.name - while this script doesnt entirely rely on that the whole detection can still be simplified

@theKashey
Copy link
Collaborator

Wondering if https://github.com/iliakan/detect-node can be used for the same purpose. And it doesn't - then this sort of configuration should be left up to the particular user.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants