Supporting navigation to / and basePath when basePath is defined #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5cd5b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
liamqma
previously approved these changes
Feb 28, 2025
liamqma
reviewed
Feb 28, 2025
.changeset/ninety-penguins-speak.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "react-resource-router": patch | |||
There was a problem hiding this comment.
To be safe it needs to be a minor I think. Although we've fixed a bug, we've also introduced a new behaviour - allow / if basePath is set.
liamqma
approved these changes
Feb 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current issue is that when
basePathis defined (e.g./base), even when we pass in/and/baseas routes to RRR, navigating tourl.com/orurl.com/baseresults in a 404, because/becomes/base/and/basebecomes/base/basewhen trying to find matching routes, and so now no routes match
/or/base. This PR is making an update so that when the user is navigating to/or/basethe base path is ignored and they become valid routes to match on./base/is still a valid route