-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
1st argument changes, remove "path" and "url" options, bug fixes #251
Conversation
Hey Alex! Thanks for your work on this! I used this library for a toy project over the weekend and it was fairly seamless. I saw in the issue thread that sparked this your consideration of a I have a slight preference for a |
@JonKrone I've been doing a lot of research on all the various patterns people use. It seems swr and react-query are blocking fetches with a |
@JonKrone After looking at it more, seems like @apollo/react-hooks has significantly more downloads and significantly more people using it. I might do the |
I wish there was a way to crowd source people's opinions on this. |
I found a way to crowdsource people's opinions on reddit. See the poll here on whether to use |
Going to let more people vote before adding conditional auto-managed state. Gonna get these fixes in now though. |
Summary
path
andurl
fields in exchange for the 1st argument handling both. Auto managed useFetch doesn't append URL to provider #247BREAKING CHANGE 🚨
Fixes issue when overwriting global options, it changes for every instance of useFetch. Deleting a global option persists for all instances #250
fixes the pagination issue here loading bug with cache? #237 but might not fix the
loading
bug.small bug fix with
responseType
Todos
useFetch('path')
without the/
in the path (might be fine with the current tests)path
to explain how the new way workspath
andurl
options. I think it's just this one and this one