Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#355: dependencies with undefined value will not do http request #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#355: dependencies with undefined value will not do http request #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/useFetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
} from './types'
import useFetchArgs from './useFetchArgs'
import doFetchArgs from './doFetchArgs'
import { invariant, tryGetData, toResponseObject, useDeepCallback, isFunction, sleep, makeError } from './utils'
import { invariant, tryGetData, toResponseObject, useDeepCallback, isFunction, sleep, makeError, isEmpty } from './utils'
import useCache from './useCache'

const { CACHE_FIRST } = CachePolicies
Expand Down Expand Up @@ -229,11 +229,15 @@ function useFetch<TData = any>(...args: UseFetchArgs): UseFetch<TData> {
// onMount/onUpdate
useEffect((): any => {
mounted.current = true
if (Array.isArray(dependencies)) {
const methodName = requestInit.method || HTTPMethod.GET
const methodLower = methodName.toLowerCase() as keyof ReqMethods<TData>
const req = request[methodLower] as NoArgs
req()
if (
Array.isArray(dependencies) &&
(dependencies.length === 0 ||
dependencies.filter((d) => !isEmpty(d)).length > 0)
) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkrafi are there any unit tests/tests relevant to this feature ? for the newly added/fixed one and existing functionality
So it will be easy to review ?

const methodName = requestInit.method || HTTPMethod.GET;
const methodLower = methodName.toLowerCase() as keyof ReqMethods<TData>;
const req = request[methodLower] as NoArgs;
req();
}
return () => mounted.current = false
}, dependencies)
Expand Down