Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DynamoDB Enhanced - Change to use regex pattern for the attribute name cleaner #5677

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

debora-ito
Copy link
Member

Motivation and Context

The attribute name sanitizer checked for a specific list of special characters, but the list was not comprehensive of all the valid special characters for a dynamo attribute name.

Attribute names with a character that was valid but not in the list would get an error like

ExpressionAttributeNames contains invalid key: Syntax error; key: "#AMZN_MAPPED_FirstName+LastName"

Customers submitted issues asking to add a new special character to the list (#3058 | #3139 | #3945 | #5603). This change will help prevent similar issues in the future.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

License

  • I confirm that this pull request can be released under the Apache 2 license

@debora-ito debora-ito requested a review from a team as a code owner October 23, 2024 23:47
L-Applin
L-Applin previously approved these changes Oct 25, 2024
@L-Applin
Copy link
Contributor

L-Applin commented Oct 25, 2024

Running the unit tests, two of them are failing in the codebuild jobs:

  • ProjectionExpressionTest.severalNestedAttributes_handledCorrectly
  • ProjectionExpressionTest. severalTopLevelAttributes_handledCorrectly

Notably, they check that the firstiteminlist[0] attribute handled correctly, should square brackets be excluded?

@L-Applin L-Applin self-requested a review October 25, 2024 18:25
@L-Applin L-Applin dismissed their stale review October 25, 2024 18:29

some unit test are failing

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants