Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor RequestBatchBuffer to seperate out flush policy and batch storage[DRAFT] #5926

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor RequestBatchBuffer to seperate out flush policy and batch storage[DRAFT] #5926

wants to merge 2 commits into from

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Mar 5, 2025

[DRAFT]

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner March 5, 2025 00:17
joviegas
joviegas commented Mar 5, 2025
View reviewed changes
...sqs/src/main/java/software/amazon/awssdk/services/sqs/internal/batchmanager/FlushPolicy.java
}

// Updated method signature to use the same generic types
private <ResponseT> boolean isByteSizeThresholdCrossed(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for Concurrent execution when Byte Size close to threshold

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 9, 2025

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joviegas