-
Notifications
You must be signed in to change notification settings - Fork 895
Remove ToDo showing up in public facing API reference #6015
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @ambikab thank you for the PR. We shouldn't remove the TODO though, just hide it from the public Javadoc comment. You can replace |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll start the builds.
|
* Remove ToDo showing up in public facing API reference * Hide ToDos appearing on public javadoc --------- Co-authored-by: Ambika Babuji <ambikab@amazon.com> Co-authored-by: Debora N. Ito <476307+debora-ito@users.noreply.github.com>
There may be some checkstyle checks failing, taking a look. |
Motivation and Context
Solves: #5523
Modifications
Removed a ToDo from a public facing documentation.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License