Skip to content

Remove fast unmarshaller dialup code #6050

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Apr 24, 2025

Conversation

sugmanue
Copy link
Contributor

@sugmanue sugmanue commented Apr 22, 2025

Motivation and Context

Clean up the code to enable the fast unmarshalling code path. Now that the last wave went in we are removing it.

I will create a follow up to clean up the customization.config files to avoid that noise in this change.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sugmanue sugmanue marked this pull request as ready for review April 23, 2025 15:41
@sugmanue sugmanue requested a review from a team as a code owner April 23, 2025 15:41
@sugmanue sugmanue enabled auto-merge April 23, 2025 15:41
@sugmanue sugmanue added this pull request to the merge queue Apr 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@sugmanue sugmanue added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@sugmanue sugmanue added this pull request to the merge queue Apr 24, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 24, 2025
* Remove fast unmarshaller dialup code

* Further cleanup and checkstyle fixes

* Add the @deprecated javadoc tag

* Add back the SdkClientJsonProtocolAdvancedOption class

* Remove the parser setter, we don't need to be backwards compatible
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@sugmanue sugmanue added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@sugmanue sugmanue added this pull request to the merge queue Apr 24, 2025
@sugmanue sugmanue removed this pull request from the merge queue due to a manual request Apr 24, 2025
@sugmanue sugmanue enabled auto-merge April 24, 2025 20:31
@sugmanue sugmanue added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@sugmanue sugmanue added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@sugmanue sugmanue added this pull request to the merge queue Apr 24, 2025
Merged via the queue into master with commit d8588e1 Apr 24, 2025
27 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants