-
Notifications
You must be signed in to change notification settings - Fork 895
Remove fast unmarshaller dialup code #6050
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanVaknin
approved these changes
Apr 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
* Remove fast unmarshaller dialup code * Further cleanup and checkstyle fixes * Add the @deprecated javadoc tag * Add back the SdkClientJsonProtocolAdvancedOption class * Remove the parser setter, we don't need to be backwards compatible
Fred1155
approved these changes
Apr 24, 2025
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Clean up the code to enable the fast unmarshalling code path. Now that the last wave went in we are removing it.
I will create a follow up to clean up the
customization.config
files to avoid that noise in this change.Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License