feat: add ide category to auto-trigger threshold computation #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JB and VSC need different IDE cofficients for auto trigger threshold
| const autoTriggerResult = autoTrigger({ | ||
| fileContext, // The left/right file context and programming language | ||
| lineNum: params.position.line, // the line number of the invocation, this is the line of the cursor | ||
| char: triggerCharacter, // Add the character just inserted, if any, before the invication position | ||
| ide: '', // TODO: Fetch the IDE in a platform-agnostic way (from the initialize request?) | ||
| ide: ideCategory ?? "VSCODE", |
There was a problem hiding this comment.
should we be defaulting to vscode here? or reject if the ideCategory isn't defined?
There was a problem hiding this comment.
so when this feature was developed we were only supporting JB and VSC, and for all other IDEs, there isn't a coefficient for them, I think the current logic for other IDEs is that they will use VSC coefficient and this change is remaining this behavior.
There was a problem hiding this comment.
acutally for VSC we will have a negative shift, for all other IDEs they will be 0.
other IDE's value should be 0
jpinkney-aws
approved these changes
Apr 25, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JB and VSC need different IDE cofficients for auto trigger threshold
Problem
JB and VSC need different IDE cofficients for auto trigger threshold
Solution
Pass IDE category as the parameter and get different coefficient based on this info
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.