Skip to content

Add target_container_hostname to base predictor #5196

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kwnath
Copy link

@kwnath kwnath commented Jun 6, 2025

I noticed that we're not specifying the target_container_hostname when executing predict, just adding this here.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kwnath kwnath requested a review from a team as a code owner June 6, 2025 19:36
@kwnath kwnath requested a review from nargokul June 6, 2025 19:36
@@ -203,6 +207,7 @@ def predict(
target_variant=target_variant,
inference_id=inference_id,
custom_attributes=custom_attributes,
target_container_hostname=target_container_hostname,
Copy link
Author

@kwnath kwnath Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this doesn't work when running something like:

response = runtime_sm_client.invoke_endpoint(
    EndpointName="endpoint",
    ContentType="application/json",
    TargetModel="target_model",
    TargetContainerHostname="primary",
    Body="...",
)

Returns:
ValidationError: An error occurred (ValidationError) when calling the InvokeEndpoint operation: Request x endpoint does not support TargetContainerHostname

@kwnath kwnath requested a deployment to manual-approval June 16, 2025 10:31 — with GitHub Actions Waiting
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant