Request response client creation and skeleton #327
+517
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazhvera
changed the title
xiazhvera
changed the title
bretambrose
reviewed
Apr 17, 2025
Source/AwsCommonRuntimeKit/mqtt/MqttRequestResponseClient.swift
Outdated
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/mqtt/MqttRequestResponseClient.swift
Outdated
Show resolved
Hide resolved
| * A streaming operation is automatically closed (and an MQTT unsubscribe triggered) when its | ||
| * destructor is invoked. | ||
| */ | ||
| public class StreamingOperation { |
There was a problem hiding this comment.
This will need a public/core pair of objects because closing the operation is asynchronous and you can continue to receive callbacks for some time after release the operation
Source/AwsCommonRuntimeKit/mqtt/MqttRequestResponseClient.swift
Outdated
Show resolved
Hide resolved
bretambrose
reviewed
Apr 17, 2025
Source/AwsCommonRuntimeKit/mqtt/MqttRequestResponseClient.swift
Outdated
Show resolved
Hide resolved
sbSteveK
reviewed
Apr 17, 2025
Source/AwsCommonRuntimeKit/mqtt/MqttRequestResponseClient.swift
Outdated
Show resolved
Hide resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.