Skip to content

Changelog nitpick, change avax explorer #232

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Apr 7, 2025

Description

Change default avax explorer (contracts are now verified there too); Tenderly doesn't seem to be using snowtrace.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb April 7, 2025 13:07
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to remember adding a custom chain for Avalanche at one point, and taking it out. Let's see if it works.

@@ -30,7 +30,7 @@
- Deployed V3 Gyro E-CLP Factory to all networks.
- Deployed V3 Gyro 2-CLP Factory to all networks.
- Deployed V3 Stable Pool Factory V2 to all networks.
- Deployed V3 Stable Surg Hook V2 to all networks.
- Deployed V3 Stable Surge Hook V2 to all networks.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed in #231 :) Didn't want to make a separate PR just for that.

@@ -472,7 +472,7 @@ export default {
etherscan: {
customChains: [
{
network: 'zkemv',
network: 'zkevm',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did that ever work then? Is it not using the custom chain? Does it work if we just delete that network?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for the explorers; it doesn't have any other consequences.

@jubeira jubeira merged commit 6270111 into master Apr 7, 2025
42 checks passed
@jubeira jubeira deleted the nitpick-avax-explorer branch April 7, 2025 14:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants