Skip to content

Conversation

jspizziri
Copy link
Contributor

…entityType

#9

@jspizziri
Copy link
Contributor Author

@bashleigh , I finally got around to taking a crack at this PR nearly 2yrs on.

With that said, I consider it very much a WIP, in so far as, it's working for my use-case and all the tests are passing. However, I think it needs some scrutiny as I was just playing fast and loose with the code. Not sure it's super elegant either... but hey, it does work for me :D.

The biggest scenario that I don't think is covered is when you're querying up from child to parent. It doesn't look like there's a test in the spec files for that and I don't do that in my app. If you look at it and think it's a workable shot at it I can add a test for it.

@jspizziri
Copy link
Contributor Author

@bashleigh friendly ping.

@bashleigh
Copy link
Owner

Sorry, I did see it, I've not been with it for a while. I need to take some time to remember what the hell was gonig through my head when I wrote all this and get myself back up to speed with all the craziness within the repo 😅

Hopefully I'll find some time next week. In fact, I'll put it in my calendar 👍🏼

@bashleigh
Copy link
Owner

@jspizziri don't suppose you can resolve the conflicts? If not I'll see if I can sort them. I've had a look but again I'm so unfamiliar with this repository now. I've found one part I wanted to add a code change suggestion to but it's a bit too much to do in github comment block so will look at doing it in VSC and see what I can do

@jspizziri
Copy link
Contributor Author

@bashleigh working on resolving these. also doing some refactoring based on the new changes. might be a while before I have things ready for review again. stay tuned.

@jspizziri jspizziri force-pushed the perf/hydrate-many branch from c826ab9 to 1e6d02d Compare May 28, 2025 16:50
@jspizziri
Copy link
Contributor Author

@bashleigh , at long last I believe I've got batch hydration working. I've added an additional test and all the existing tests are passing. It also looks like the github CI might be broken, I pushed a commit that might fix that.

@jspizziri jspizziri force-pushed the perf/hydrate-many branch from 79cc0a3 to 99eba16 Compare May 28, 2025 16:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants