Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: permit nullable parent #48

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

solanamonk
Copy link
Contributor

At the moment, if there is a record whose entityType and entityId are null, you get an exception when it gets hydrated:

EntityMetadataNotFoundError: No metadata for "null" was found.

This pull request makes it possible to have a nullable polymorphic parent.

Copy link
Owner

@bashleigh bashleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this looks good, good shout! Never thought of that being a requirement

@bashleigh bashleigh merged commit da645cd into bashleigh:master Mar 29, 2024
4 checks passed
@jromerof
Copy link

@bashleigh is this going to be published? 🙏 I think the last npm release was over a year ago

@bashleigh
Copy link
Owner

@jromerof my bad, I thought I'd released it! I've merged in another PR tonight so I'll get it out (y)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants