Skip to content

Fix of broadcast serialization bug #530

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

arrjon
Copy link
Member

@arrjon arrjon commented Jul 2, 2025

Simple fix for #529. However, I am not sure, if this is a fix for a symptom only or if something in the serialization has to be fixed.

@arrjon arrjon changed the title simple fix Fix of broadcast serialization bug Jul 2, 2025
@arrjon arrjon requested a review from LarsKue July 2, 2025 13:07
@stefanradev93
Copy link
Contributor

Reminds me of the "keras doesn't like lists" issues we had @LarsKue .

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bayesflow/adapters/transforms/broadcast.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
bayesflow/adapters/transforms/broadcast.py 82.97% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@vpratz vpratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Maybe you use isinstance(self.expand, Sequence) or isinstance(self.expand, (list, tuple)) instead of the or statement, but apart from that, it looks good to me.

@arrjon arrjon marked this pull request as ready for review July 8, 2025 13:01
@vpratz vpratz merged commit f1c0c87 into dev Jul 8, 2025
8 of 9 checks passed
@vpratz vpratz deleted the 529-bug-serialization-of-the-broadcast-transformation branch July 8, 2025 14:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants