Skip to content

#165 use qunit in trinterp #166

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

#165 use qunit in trinterp #166

merged 2 commits into from
Feb 19, 2025

Conversation

tweng-bdai
Copy link
Contributor

This commit fixes issue 165.

It would benefit from a unit test, possibly the same one as referenced in the issue, but I haven't added that as I haven't set up testing.

@myeatman-bdai
Copy link
Collaborator

myeatman-bdai commented Feb 19, 2025

I added a unit test. I also made sure the unit test failed on master, without the changes to the trinterp function.

Copy link
Collaborator

@myeatman-bdai myeatman-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 THANK YOU

@myeatman-bdai myeatman-bdai merged commit 550d6fb into master Feb 19, 2025
15 checks passed
@myeatman-bdai myeatman-bdai deleted the 165-trinterp-invalid-mat branch February 19, 2025 21:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trinterp() returns invalid rotations in transform matrix
3 participants