Support derived Animate classes in order to use the same axes. #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhavl this is a rather simple yet capable improvement that provides trivial extensibility of Animate classes. Could you please give it a quick look and merge? 🙏🏼 Cc. @petercorke |
|
Looks great! I'll have a look at the change on the weekend. There's more I'd like to do with animations but this seems like a win. Thx for your interest |
|
@petercorke friendly ping 🙂 |
tahsinkose
requested review from
petercorke,
jhavl and
myeatman-bdai
as code owners
|
Another friendly ping for @jhavl and @myeatman-bdai. This is rather a simple improvement, thus should not take too much of your time. PTAL 🙏🏼 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I've been using the MATLAB version of these nice toolboxes and just recently finally had a use-case to migrate to Python. I needed to visualize multiple frames in a single animation view. In order to do that, I have to derive from
base.animate.Animateand adjust some of the internal data structures. In order to use the sameaxasbase.animate.Animatedoes, however, I had to clone this repo and make this change so that all derived classes receive the exact same treatment with the base class.