Migrate from JUnit 4 to JUnit 5 #353

mikepapadim · 2024-03-18T09:39:41Z

Description

Describe the patch. What does it enhance? What does it fix?

This PR implements the migration unit testing framework from JUnit 4 (JUnit 4.13.2 last updated Feb 13, 2021) to JUnit 5. This migration includes updating dependencies, annotations, assertions, and test instance lifecycle management.

Key changes:

Updated Dependencies: Updated the Maven dependencies to include JUnit 5 libraries (junit-jupiter-api, junit-jupiter-engine).
Annotations Updates: Migrated JUnit 4 annotations to their JUnit 5 counterparts (e.g., @before to @beforeeach, @after to @AfterEach, @BeforeClass to @BeforeAll, @afterclass to @afterall).
Assertions Updates: Transitioned to JUnit 5's assertion API which offers better assertion capabilities and error messages (org.junit.jupiter.api.Assertions).

Backend/s tested

Mark the backends affected by this PR.

OpenCL
PTX
SPIRV

OS tested

Mark the OS where this PR is tested.

Linux
OSx
Windows

How to test the new patch?

make 
make tests

[examples] bnw example improved

jjfumero · 2024-03-21T13:31:42Z

@mikepapadim , if you solve the conflicts, we can merge this PR

mikepapadim · 2024-03-21T13:53:58Z

@mikepapadim , if you solve the conflicts, we can merge this PR

Lets hold this one.

I solved the conflicts with the latest develop, but now it seems that TestBatches cause a segfault

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True "  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.batches.TestBatches"
WARNING: Using incubator modules: jdk.incubator.vector
Aborted (core dumped)

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007664629adb68, pid=79598, tid=79624
#
# JRE version: OpenJDK Runtime Environment (21.0+35) (build 21+35-2513)
# Java VM: OpenJDK 64-Bit Server VM (21+35-2513, mixed mode, tiered, jvmci, parallel gc, linux-amd64)
# Problematic frame:
# C  [libnvidia-opencl.so.1+0x1adb68]
#
# Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport -p%p -s%s -c%c -d%d -P%P -u%u -g%g -- %E" (or dumping to /home/mikepapadim/manchester/TornadoVM/core.79598)
#
# An error report file with more information is saved as:
# /home/mikepapadim/manchester/TornadoVM/hs_err_pid79598.log
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#

The rest of the tests are in par with develop:

==================================================
              Unit tests report 
==================================================

{'[PASS]': 565, '[FAILED]': 7, '[UNSUPPORTED]': 30}
Coverage [PASS/(PASS+FAIL)]: 98.78%
Coverage [PASS/(PASS+FAIL+UNSUPPORTED)]: 93.85%

==================================================

mikepapadim · 2024-03-25T16:58:51Z

[Update] SegFault also occurs with PTX for TestBatches

…apadim/junit5

mikepapadim · 2024-04-29T10:39:59Z

[Update] I merged it with the latest develop to check the event fix-up if it influences the batch processing failures.
Only, @gigiblender patch fixed the issue with batch processing, however, lazy copy-outs still fail.
Batch processing on PTX is still failing.

…apadim/junit5

mikepapadim · 2024-05-21T10:34:32Z

Thanks @gigiblender for the patch

mikepapadim · 2024-05-21T10:35:24Z

@jjfumero @stratika @mairooni when you have time can we do another iteration on testing,.

Now, it it stable to merge after we test it.

jjfumero · 2024-05-22T09:27:28Z

Let's check in OSx and Windows as well.

jjfumero · 2024-05-22T09:45:56Z

The batch processing with PTX still failing:

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True "  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.batches.TestBatches"
WARNING: Using incubator modules: jdk.incubator.vector
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007faeb1d79937, pid=53407, tid=53408
#
# JRE version: Java(TM) SE Runtime Environment (21.0.3+7) (build 21.0.3+7-LTS-152)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (21.0.3+7-LTS-152, mixed mode, tiered, jvmci, parallel gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0x979937]  jni_GetArrayLength+0x87
#
# Core dump will be written. Default location: Core dumps may be processed with "/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h" (or dumping to /home/juan/tornadovm/TornadoVM/core.53407)
#
# An error report file with more information is saved as:
# /home/juan/tornadovm/TornadoVM/hs_err_pid53407.log
[6.098s][warning][os] Loading hsdis library failed
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#

mikepapadim · 2024-05-22T10:08:53Z

The batch processing with PTX still failing:

tornado -ea  --jvm "-Xmx6g -Dtornado.recover.bailout=False -Dtornado.unittests.verbose=True "  -m  tornado.unittests/uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner  --params "uk.ac.manchester.tornado.unittests.batches.TestBatches"
WARNING: Using incubator modules: jdk.incubator.vector
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007faeb1d79937, pid=53407, tid=53408
#
# JRE version: Java(TM) SE Runtime Environment (21.0.3+7) (build 21.0.3+7-LTS-152)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (21.0.3+7-LTS-152, mixed mode, tiered, jvmci, parallel gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0x979937]  jni_GetArrayLength+0x87
#
# Core dump will be written. Default location: Core dumps may be processed with "/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h" (or dumping to /home/juan/tornadovm/TornadoVM/core.53407)
#
# An error report file with more information is saved as:
# /home/juan/tornadovm/TornadoVM/hs_err_pid53407.log
[6.098s][warning][os] Loading hsdis library failed
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#

thats weird cause in my configuration with Driver Version: 550.67 CUDA Version: 12.4 it works

…apadim/junit5

mikepapadim · 2024-09-04T08:27:18Z

@jjfumero @stratika @mairooni
I did another iteration on this one to sync it with the latest develop.
Batches now pass without causing a segfault.

However, now multithreaded.TestMultiThreadedExecutionPlans causes a segfault.

Also, I updated the version of JUNIT5 to the latest as per 5.11.0.

jjfumero · 2024-09-04T15:42:21Z

Thanks @mikepapadim . Let's sync next week to tackle this.

jjfumero and others added 4 commits March 18, 2024 11:15

Merge pull request beehive-lab#347 from jjfumero/fix/examples

4845f0c

[examples] bnw example improved

Refactor TornadoHelper in unit tests for optimization.

c27eea8

Remove junit-vintage-engine dependency from pom.xml

18b4468

Refactor TestBatches for Junit5

343e8d9

mikepapadim added the tests label Mar 18, 2024

mikepapadim requested review from jjfumero, mairooni and stratika March 18, 2024 09:39

mikepapadim self-assigned this Mar 18, 2024

jjfumero approved these changes Mar 18, 2024

View reviewed changes

mairooni approved these changes Mar 19, 2024

View reviewed changes

fix merge

f601427

mikepapadim added 2 commits March 21, 2024 15:42

Fix merge conflicts

5da10da

Fix merge conflicts

a674053

mikepapadim added 8 commits April 16, 2024 13:39

Merge remote-tracking branch 'oss/develop' into mikepapadim/junit5

84e6826

Update unit tests to use JUnit 5

2aadad4

Merge branch 'develop' of github.com:beehive-lab/TornadoVM into mikep…

80e9825

…apadim/junit5

Merge branch 'develop' into mikepapadim/junit5

a176e55

Partial fix for segfaults in OpenCL

c0d9a2c

Refactor memory allocation and test methods

8520559

Merge branch 'develop' into mikepapadim/junit5

1b50d07

Migrate unit tests to JUnit5

3d25f40

gigiblender and others added 2 commits May 20, 2024 11:27

Fix PTX code cache using an invalid module

582228e

Merge branch 'develop' of github.com:beehive-lab/TornadoVM into mikep…

1533ff4

…apadim/junit5

mikepapadim added 3 commits September 3, 2024 13:46

Merge branch 'develop' of github.com:beehive-lab/TornadoVM into mikep…

d4ee6c3

…apadim/junit5

Update JUnit versions in POM files

c7960a1

Switch from JUnit 4 to JUnit 5 and refactor asserts

0214abc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate from JUnit 4 to JUnit 5 #353

Migrate from JUnit 4 to JUnit 5 #353

Uh oh!

mikepapadim commented Mar 18, 2024

Uh oh!

jjfumero commented Mar 21, 2024 •

edited by mikepapadim

Loading

Uh oh!

mikepapadim commented Mar 21, 2024 •

edited

Loading

Uh oh!

mikepapadim commented Mar 25, 2024 •

edited

Loading

Uh oh!

mikepapadim commented Apr 29, 2024

Uh oh!

mikepapadim commented May 21, 2024

Uh oh!

mikepapadim commented May 21, 2024

Uh oh!

jjfumero commented May 22, 2024

Uh oh!

jjfumero commented May 22, 2024

Uh oh!

mikepapadim commented May 22, 2024

Uh oh!

mikepapadim commented Sep 4, 2024

Uh oh!

jjfumero commented Sep 4, 2024

Uh oh!

Uh oh!

Migrate from JUnit 4 to JUnit 5 #353

Are you sure you want to change the base?

Migrate from JUnit 4 to JUnit 5 #353

Uh oh!

Conversation

mikepapadim commented Mar 18, 2024

Description

Backend/s tested

OS tested

How to test the new patch?

Uh oh!

jjfumero commented Mar 21, 2024 • edited by mikepapadim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikepapadim commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikepapadim commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikepapadim commented Apr 29, 2024

Uh oh!

mikepapadim commented May 21, 2024

Uh oh!

mikepapadim commented May 21, 2024

Uh oh!

jjfumero commented May 22, 2024

Uh oh!

jjfumero commented May 22, 2024

Uh oh!

mikepapadim commented May 22, 2024

Uh oh!

mikepapadim commented Sep 4, 2024

Uh oh!

jjfumero commented Sep 4, 2024

Uh oh!

Uh oh!

jjfumero commented Mar 21, 2024 •

edited by mikepapadim

Loading

mikepapadim commented Mar 21, 2024 •

edited

Loading

mikepapadim commented Mar 25, 2024 •

edited

Loading