fix: the worker_abort hook interrupted after executing part #3337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingyun123
force-pushed
the
fix-3336-worker_abort-hook
branch
from
8b8c2ea to
73ae038
Compare
bingyun123
force-pushed
the
fix-3336-worker_abort-hook
branch
from
73ae038 to
0676087
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When a custom worker_abort hook contains time-consuming operations, it will be interrupted after executing part of it.
Closes #3336
Solve:
I change worker.aborted flag after kill_worker and it works fine