Skip to content

Fix order of import statements for shapely issue #23

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Jun 22, 2023

No description provided.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Copy link
Owner

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's not useful. As I already mentioned in the original issue, we cannot control all the places where this happens, anyway. (For example, shapely gets imported by ocrd_utils earlier, simply by the CLI decorator...)

@stweil
Copy link
Contributor Author

stweil commented Jun 22, 2023

It's true that such less obvious imports make it difficult to find all affected code locations by a simple code inspection.

But it would still be possible to fix the issue like that case by case.

The current workaround to run pip install --no-binary shapely --force-reinstall shapely has also drawbacks.

@bertsky
Copy link
Owner

bertsky commented Jun 22, 2023

I agree in principle. But we know that core itself, which is used everywhere (CLI decorators), always imports shapely (via ocrd_validators, via ocrd) – before anything else. So that would need to be solved first...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants