Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Styling: Use transparent Biopython logo #15

Closed
peterjc opened this issue Apr 13, 2016 · 7 comments
Closed

Styling: Use transparent Biopython logo #15

peterjc opened this issue Apr 13, 2016 · 7 comments

Comments

@peterjc
Copy link
Member

peterjc commented Apr 13, 2016

Following discussion on #3, @widdowquinn has prepared some updated logo images currently at biopython/biopython#807 which could be used here for the website. This would allow the grey background to be changed more freely (currently matching the dark grey of the logo image).

Also the way I inserted the logo into the hyde template was not very elegant. That could be done better.

peterjc added a commit that referenced this issue May 10, 2016
Lots of markup tweaking in the building-a-release file.
Still needs updating now that the website is on GitHub Pages
(see issue #15).

Also switched to using restructuredtext as the default with
epydoc (was previously plain text).
@MarkusPiotrowski
Copy link
Contributor

Suggestion for two little changes to the sidebar:

  1. Transparent Biopython logo
  2. Put 'non-navigation' elements to the bottom of the sidebar

Before:
untitled-1

After:
untitled-2

OK?

@peterjc
Copy link
Member Author

peterjc commented May 12, 2016

Looks nice - I was meaning to grab the logo @widdowquinn prepared on biopython/biopython#807 and add it to this repository instead (committing under his name), perhaps at the same time resolving #25.

@MarkusPiotrowski
Copy link
Contributor

No problem, I think they are nearly identical (I guess Leighton and I have used the same template and deleted automatically the white background).
However, can you downscale this to a width of ~600 px? In the sidebar, we need only about 200 px maximum, but as 'top'-bar it can be bigger.
You can temporarily check how it looks with @widdowquinn transparent logo (width: 600 px) here:
http://markuspiotrowski.github.io

@MarkusPiotrowski
Copy link
Contributor

Here I adjusted the navigation for mobiles, having the links next to each other instead of one below the other. Also reduced the margins (in this view) to have more content. This touches slightly #26.

untitled-1

Again, this can be tested temporarily here: http://markuspiotrowski.github.io
@peterjc When the transparent logo is committed I would prepare a pull request

@peterjc
Copy link
Member Author

peterjc commented May 13, 2016

That does work better for mobiles 👍

peterjc added a commit that referenced this issue May 22, 2016
@MarkusPiotrowski
Copy link
Contributor

Looks much better now!

@peterjc
Copy link
Member Author

peterjc commented May 22, 2016

Great. We're now free to change the dark grey background colour now that the logo background is transparent.

@peterjc peterjc closed this as completed May 22, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants