test: exclude failing aimes test cases #1407
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses: boostorg#1403 The Aimes test cases are a set of complex real life features which are not yet totally robust for geographic buffers.
barendgehrels
commented
May 10, 2025
| @@ -29,6 +29,8 @@ endforeach() | |||
| foreach(item IN ITEMS | |||
| buffer_point_geo | |||
| buffer_polygon_geo | |||
| buffer_linestring | |||
There was a problem hiding this comment.
This one was fine without adaptions
barendgehrels
commented
May 10, 2025
| @@ -29,6 +29,8 @@ endforeach() | |||
| foreach(item IN ITEMS | |||
| buffer_point_geo | |||
| buffer_polygon_geo | |||
| buffer_linestring | |||
| buffer_linestring_geo | |||
There was a problem hiding this comment.
For this case I had to exclude 5 cases.
I will investigate them later this year, after integrating some other enhancements (robust side, #1404, ...)
barendgehrels
commented
May 10, 2025
| @@ -149,6 +173,8 @@ int test_main(int, char* []) | |||
| test_linestring<bg::strategy::andoyer, true, bg::model::point<default_test_type, 2, bg::cs::geographic<bg::degree> > >(); | |||
| test_linestring<bg::strategy::thomas, true, bg::model::point<default_test_type, 2, bg::cs::geographic<bg::degree> > >(); | |||
|
|
|||
| test_linestring_aimes<bg::strategy::andoyer, true, bg::model::point<default_test_type, 2, bg::cs::geographic<bg::degree> > >(); | |||
There was a problem hiding this comment.
This is not run for thomas for speed and complexity reasons
barendgehrels
commented
May 10, 2025
| // Cases where the algorithm is still failing. | ||
| std::set<int> const skip_cases_round_round{17, 22, 38, 181, 196}; | ||
| std::set<int> const skip_cases_round_flat{17, 22, 38, 103, 196}; | ||
| std::set<int> const skip_cases_miter_flat{17, 18, 22, 38, 103, 196}; |
There was a problem hiding this comment.
196 was already skipped (in another way, see below).
Two other cases were already skipped but are now fine.
vissarion
approved these changes
May 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses: #1403
The Aimes test cases are a set of complex real life features which are not yet totally robust for geographic buffers.