Skip to content

localProxyHost requires an additional dash #61

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattonem
Copy link

We add some syntactic sugar for proxyHost, Local will automatically add a dash a that beginning of the parameter name.
see link:

parameters.put("proxyHost", "-proxyHost");

But don't have the same behavior with localProxyHost. So we must use -localProxyHost instead.

Same for localProxyPort

We add some syntactic sugar for `proxyHost`, Local will automatically add a dash a that beginning of the parameter name. 
see link: https://github.com/browserstack/browserstack-local-java/blob/3ffdab3366fa24e6d0809da5093b200cf7be8794/src/main/java/com/browserstack/local/Local.java#L42
But don't have the same behavior with localProxyHost. So we must use `-localProxyHost` instead.

Same for localProxyPort
@zigasternad
Copy link

+1

Why is this PR not merged?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants