fix: add --no-border-checks flag to recover from source-map-explorer errors #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
feat/no-border-checks
branch
from
d95b02e to
3fc2f0d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On latest few versions of React Native (checked on 0.75 and above), the
source-map-explorerdependency is crashing by incorrect mappings produced by Metro bundler:which bleeds to
react-native-bundle-visualizer:To fix that, we can pass
--no-border-checksflag tosource-map-explorer, which avoids failure and can still produce the visual information, at least in my test project. As a non-breaking solution I'm adding the same flag to thereact-native-bundle-visualizerTest Plan